[
https://issues.apache.org/jira/browse/MESOS-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943736#comment-14943736
]
Neil Conway commented on MESOS-3326:
------------------------------------
Re-opening this because there's a few remaining places in which we need to use
std::atomic--
libprocess/src/tests/process.cpp
libprocess/include/process/owned.hpp
libprocess/include/process/shared.hpp
libprocess/include/process/logging.hpp
> Make use of C++11 atomics
> -------------------------
>
> Key: MESOS-3326
> URL: https://issues.apache.org/jira/browse/MESOS-3326
> Project: Mesos
> Issue Type: Bug
> Reporter: Neil Conway
> Assignee: Neil Conway
> Fix For: 0.25.0
>
>
> Now that we require C++11, we can make use of std::atomic. For example:
> * libprocess/process.cpp uses a bare int + __sync_synchronize() for "running"
> * __sync_synchronize() is used in logging.hpp in libprocess and fork.hpp in
> stout
> * sched/sched.cpp uses a volatile int for "running" -- this is wrong,
> "volatile" is not sufficient to ensure safe concurrent access
> * "volatile" is used in a few other places -- most are probably dubious but I
> haven't looked closely
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
