[
https://issues.apache.org/jira/browse/MESOS-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962823#comment-14962823
]
Michael Park commented on MESOS-3326:
-------------------------------------
{noformat}
commit 5882d4a2189f954f093e824e5bf04f32a7954697
Author: Neil Conway <[email protected]>
Date: Sun Oct 18 21:30:32 2015 -0700
Fixed typo in comment, minor style fixes.
Review: https://reviews.apache.org/r/39428
{noformat}
> Make use of C++11 atomics
> -------------------------
>
> Key: MESOS-3326
> URL: https://issues.apache.org/jira/browse/MESOS-3326
> Project: Mesos
> Issue Type: Bug
> Reporter: Neil Conway
> Assignee: Neil Conway
> Fix For: 0.26.0
>
>
> Now that we require C++11, we can make use of std::atomic. For example:
> * libprocess/process.cpp uses a bare int + __sync_synchronize() for "running"
> * __sync_synchronize() is used in logging.hpp in libprocess and fork.hpp in
> stout
> * sched/sched.cpp uses a volatile int for "running" -- this is wrong,
> "volatile" is not sufficient to ensure safe concurrent access
> * "volatile" is used in a few other places -- most are probably dubious but I
> haven't looked closely
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
