[
https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053596#comment-15053596
]
Tobi Knaup commented on MESOS-4114:
-----------------------------------
[~sargun] DiscoveryInfo was meant to be the thing that clients or service
discovery systems read. The local port seems like an implementation detail that
should not be visible to clients. Back when this proto was introduced there was
a lot of debate around whether name etc. should just go into labels or if there
should be explicit members, and the decision was to be explicit, so I'd
recommend a new vip member to follow that pattern. There was an assumption that
each container would have it's own IP and instances of the service would listen
on the same port that is listed in DiscoveryInfo, so there would be no need to
call out the local port. In the absence of IP per container I think it makes
sense to add a new member to Port called localPort or instancePort.
I'm not sure I understand the second point - different services will have
different TaskInfo/ExecutorInfo and therefore different DiscoveryInfo, so you
can set different names and IPs.
> Add field VIP to message Port
> -----------------------------
>
> Key: MESOS-4114
> URL: https://issues.apache.org/jira/browse/MESOS-4114
> Project: Mesos
> Issue Type: Wish
> Reporter: Sargun Dhillon
> Assignee: Avinash Sridharan
> Priority: Trivial
> Labels: mesosphere
>
> We would like to extend the Mesos protocol buffer 'Port' to include an
> optional repeated string named "VIP" - to map it to a well known virtual IP,
> or virtual hostname for discovery purposes.
> We also want this field exposed in DiscoveryInfo in state.json.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
