[
https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082060#comment-15082060
]
Jie Yu commented on MESOS-4114:
-------------------------------
Based on the code committed, here are my thoughts and questions:
1) The current implementation supports multiple VIPs per DiscoveryInfo. Say we
have two VIPs: VIP_A and VIP_B and two Ports: Port_A and Port_B. How do we
specify that VIP_A is only associated with Port_A and VIP_B is only associated
with VIP_B? If we want to support that, does that mean that we need to add VIP
to Port? Will that make this patch a tech debt. IMO, network address
translation (NAT) typically involves not just IP but IP:Port tuple. Not sure if
having VIP alone is that useful.
2) What does 'instance_port' mean? After reading the comments, I am still not
sure what that means. How is 'instance_port' related to the discovery of the
service? Shouldn't VIP:Port.number be sufficient?
Final question, why this needs to be a first class thing? Sounds like VIP is
not a very 'standard' thing (unlike others like port, etc.). Can we make it a
label instead?
> Add field VIP to message Port
> -----------------------------
>
> Key: MESOS-4114
> URL: https://issues.apache.org/jira/browse/MESOS-4114
> Project: Mesos
> Issue Type: Wish
> Reporter: Sargun Dhillon
> Assignee: Avinash Sridharan
> Priority: Trivial
> Labels: mesosphere
> Fix For: 0.27.0
>
>
> We would like to extend the Mesos protocol buffer 'Port' to include an
> optional repeated string named "VIP" - to map it to a well known virtual IP,
> or virtual hostname for discovery purposes.
> We also want this field exposed in DiscoveryInfo in state.json.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
