[
https://issues.apache.org/jira/browse/MESOS-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131238#comment-15131238
]
Benjamin Mahler commented on MESOS-2814:
----------------------------------------
[~tillt] [~ijimenez]: this ticket looks stale? I only see two signatures in
read.hpp, one that takes an fd and one that takes a path:
{code}
inline Result<std::string> read(int fd, size_t size);
inline Try<std::string> read(const std::string& path);
{code}
> os::read should have one implementation
> ---------------------------------------
>
> Key: MESOS-2814
> URL: https://issues.apache.org/jira/browse/MESOS-2814
> Project: Mesos
> Issue Type: Improvement
> Components: stout
> Reporter: Cody Maloney
> Assignee: Isabel Jimenez
> Labels: mesosphere, tech-debt
>
> Currently stout os::read() has two radically different implementations when
> you give it a {{std::string}} vs. a {{const char *}}. Ideally these have one
> implementation that does things like intelligently size the buffer that it
> writes into rather than re-allocating repeatedly with every time it lengthens
> the string (resulting in copious copying).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
