[
https://issues.apache.org/jira/browse/MESOS-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131244#comment-15131244
]
Cody Maloney commented on MESOS-2814:
-------------------------------------
In master there are currently three implementations of the function:
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp#L42
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp#L82
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp#L42
All of them have fairly radically different implementations (One uses C read(),
one uses c++ ifstream, one uses c fopen)
> os::read should have one implementation
> ---------------------------------------
>
> Key: MESOS-2814
> URL: https://issues.apache.org/jira/browse/MESOS-2814
> Project: Mesos
> Issue Type: Improvement
> Components: stout
> Reporter: Cody Maloney
> Assignee: Isabel Jimenez
> Labels: mesosphere, tech-debt
>
> Currently stout os::read() has two radically different implementations when
> you give it a {{std::string}} vs. a {{const char *}}. Ideally these have one
> implementation that does things like intelligently size the buffer that it
> writes into rather than re-allocating repeatedly with every time it lengthens
> the string (resulting in copious copying).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
