[ 
https://issues.apache.org/jira/browse/MESOS-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215433#comment-15215433
 ] 

Jie Yu commented on MESOS-5049:
-------------------------------

commit b2cab0deb285a91d1442df6ea2c8b54da1e59158
Author: Joerg Schad <[email protected]>
Date:   Mon Mar 28 22:03:49 2016 -0700

    Fixed typo in subprocess doxygen comments.
    
    Review: https://reviews.apache.org/r/45401/

commit e67ad670cd4db7ee7571576db047463c7dc60733
Author: Joerg Schad <[email protected]>
Date:   Mon Mar 28 22:03:24 2016 -0700

    Adapted port_mapping isolator with missing subprocess parameter.
    
    Review: https://reviews.apache.org/r/45400/

> Refactore subproces setup functions.
> ------------------------------------
>
>                 Key: MESOS-5049
>                 URL: https://issues.apache.org/jira/browse/MESOS-5049
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Joerg Schad
>            Assignee: Joerg Schad
>             Fix For: 0.29.0
>
>
> Executing arbitrary setup functions while creating new processes is
> dangerous as all functions called have to be async safe. As setup
> functions are used for only very few purposes (setsid, chdir, monitoring
> and killing a process (see upcoming review) it makes sense to support
> them safely via parameters to subprocess. 
> Another common use of child setup are is to block the child while doing some 
> work in the parent. This pattern can be more cleanly expressed with 
> parentHooks. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to