[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248623#comment-15248623
]
Greg Mann commented on MESOS-5060:
----------------------------------
Hi [~dongdong], thanks for the patch! Sorry that I didn't get back to you about
your design yesterday.
I would propose the following: let's first get a patch merged which just fixes
the bug, and then we can consider how to best implement the semantics that we
would like for the {{/read}} endpoint. That way, we can fix the bug ASAP and
then take some time to get the new behavior right.
There is currently a design doc in progress which will be introducing a
versioned operator HTTP API (MESOS-4791), so it's possible that we could wait
to implement the new semantics until that work is implemented. Then, we could
also avoid introducing breaking changes into the existing {{/read}} endpoint.
I've made a couple comments in your existing patch; would you mind posting
another patch which only fixes the existing bug (along with a test that
verifies the bug is fixed)?
Thanks!! :-)
> Requesting /files/read.json with a negative length value causes subsequent
> /files requests to 404.
> --------------------------------------------------------------------------------------------------
>
> Key: MESOS-5060
> URL: https://issues.apache.org/jira/browse/MESOS-5060
> Project: Mesos
> Issue Type: Bug
> Affects Versions: 0.23.0
> Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX
> Reporter: Tom Petr
> Assignee: zhou xing
> Priority: Minor
> Fix For: 0.29.0
>
>
> I accidentally hit a slave's /files/read.json endpoint with a negative length
> (ex. http://hostname:5051/files/read.json?path=XXX&offset=0&length=-100). The
> HTTP request timed out after 30 seconds with nothing relevant in the slave
> logs, and subsequent calls to any of the /files endpoints on that slave
> immediately returned a HTTP 404 response. We ultimately got things working
> again by restarting the mesos-slave process (checkpointing FTW!), but it'd be
> wise to guard against negative lengths on the slave's end too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
