[ 
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278957#comment-15278957
 ] 

Greg Mann commented on MESOS-5060:
----------------------------------

Hi [~dongdong]! My mistake: your current patch actually breaks the pailer 
({{src/webui/master/static/pailer.html}}, 
{{src/webui/master/static/js/jquery.pailer.js}}), which is used to display 
files in the web UI. We should be sure to test your patch by doing the 
following:
* Start a master
* Start an agent
* Run the test framework ({{build/src/test-framework}})
* Look in the web UI at the {{stdout}} of one of the test framework's tasks and 
confirm that it displays correctly

The problem is that the pailer intentionally sets {{length = -1}} on its first 
request in order to determine the length of the file. I think that we should 
leave the pailer as it is right now, and change it if necessary when MESOS-5334 
is worked on?

So for the current patch, perhaps we can allow {{length == -1}} and treat it 
the same as when the length parameter is not provided?

> Requesting /files/read.json with a negative length value causes subsequent 
> /files requests to 404.
> --------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-5060
>                 URL: https://issues.apache.org/jira/browse/MESOS-5060
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>         Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX
>            Reporter: Tom Petr
>            Assignee: zhou xing
>            Priority: Minor
>             Fix For: 0.29.0
>
>
> I accidentally hit a slave's /files/read.json endpoint with a negative length 
> (ex. http://hostname:5051/files/read.json?path=XXX&offset=0&length=-100). The 
> HTTP request timed out after 30 seconds with nothing relevant in the slave 
> logs, and subsequent calls to any of the /files endpoints on that slave 
> immediately returned a HTTP 404 response. We ultimately got things working 
> again by restarting the mesos-slave process (checkpointing FTW!), but it'd be 
> wise to guard against negative lengths on the slave's end too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to