[
https://issues.apache.org/jira/browse/MESOS-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314676#comment-15314676
]
Neil Conway commented on MESOS-4091:
------------------------------------
Not sure this qualifies as a bug. Maybe it would have been better to use index
6 (if indeed it was never used in the past), but (a) should be harmless (b) not
much we can do about it now, without breaking backward compatibility.
> Mesos protobuf message definition ContainerInfo skipped an index.
> -----------------------------------------------------------------
>
> Key: MESOS-4091
> URL: https://issues.apache.org/jira/browse/MESOS-4091
> Project: Mesos
> Issue Type: Bug
> Reporter: Till Toenshoff
>
> Looking at {{include/mesos/mesos.proto}}:
> {noformat}
> /**
> * Describes a container configuration and allows extensible
> * configurations for different container implementations.
> */
> message ContainerInfo {
> // All container implementation types.
> enum Type {
> DOCKER = 1;
> MESOS = 2;
> }
> message DockerInfo {
> // The docker image that is going to be passed to the registry.
> required string image = 1;
> // Network options.
> enum Network {
> HOST = 1;
> BRIDGE = 2;
> NONE = 3;
> }
> optional Network network = 2 [default = HOST];
> message PortMapping {
> required uint32 host_port = 1;
> required uint32 container_port = 2;
> // Protocol to expose as (ie: tcp, udp).
> optional string protocol = 3;
> }
> repeated PortMapping port_mappings = 3;
> optional bool privileged = 4 [default = false];
> // Allowing arbitrary parameters to be passed to docker CLI.
> // Note that anything passed to this field is not guaranteed
> // to be supported moving forward, as we might move away from
> // the docker CLI.
> repeated Parameter parameters = 5;
> // With this flag set to true, the docker containerizer will
> // pull the docker image from the registry even if the image
> // is already downloaded on the slave.
> optional bool force_pull_image = 6;
> }
> message MesosInfo {
> optional Image image = 1;
> }
> required Type type = 1;
> repeated Volume volumes = 2;
> optional string hostname = 4;
> // Only one of the following *Info messages should be set to match
> // the type.
> optional DockerInfo docker = 3;
> optional MesosInfo mesos = 5;
> // A list of network requests. A framework can request multiple IP addresses
> // for the container.
> repeated NetworkInfo network_infos = 7;
> }
> {noformat}
> Seems we are missing index 6 here.
> A quick history check revealed no intension to remove a former field 6 -
> hence this appears to be a bug. Checked via;
> {noformat}
> $ git log -L 1500,1515:include/mesos/mesos.proto
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
