[
https://issues.apache.org/jira/browse/MESOS-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687772#comment-15687772
]
Till Toenshoff commented on MESOS-6396:
---------------------------------------
As discussed directly, it seems we will need to do a bit of substantial
refactoring to get this covered neatly. Specifically the fact that the volumes
are taken from the {{ContainerInfo}} in {{src/docker/docker.cpp}} while most
other things are actually being stored and operated on via {{Container}} makes
this a bit more involved. We may want to change these things, move all the jazz
we see in
https://github.com/apache/mesos/blob/master/src/docker/docker.cpp#L558-L632 out
and up into the population of {{Container}}.
Without such refactor, we would have to mutate {{ContainerInfo}} rather late
for that hook and stuff it back into {{Container}} which appears to be a likely
source of bugs.
> Hooks should allow sandbox dependent environment variables.
> -----------------------------------------------------------
>
> Key: MESOS-6396
> URL: https://issues.apache.org/jira/browse/MESOS-6396
> Project: Mesos
> Issue Type: Improvement
> Affects Versions: 1.1.0
> Reporter: Till Toenshoff
> Assignee: Till Toenshoff
> Labels: containerizer, docker, hooks, module
>
> The {{slaveExecutorEnvironmentDecorator}} hook is the only one that allows
> mutating the executor environment of a Docker container. That callback has no
> means of getting the location of the sandbox. That in turn means that it is
> not possible for a hook to create files and respective environment variables
> listing paths within the sandbox for the executor to access.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
