[ 
https://issues.apache.org/jira/browse/MESOS-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838078#comment-15838078
 ] 

Adam B commented on MESOS-6396:
-------------------------------

Also:
{code}
commit 303775555be38927022b1dc641a6be936cf4ac46
Author: Till Toenshoff <[email protected]>
Date:   Tue Nov 29 22:05:46 2016 +0100

    Removed superseded `slavePreLaunchDockerHook` hook.
    
    Review: https://reviews.apache.org/r/54174/

commit 63cc0fb49a0370d596e2c9cf87c6c5025372dd15
Author: Till Toenshoff <[email protected]>
Date:   Tue Nov 29 22:05:39 2016 +0100

    Fixed conflict in hook result handling.
    
    Review: https://reviews.apache.org/r/54165/

commit 1fe9876ca069162e46cc2436384e8d5da2b9d551
Author: Till Toenshoff <[email protected]>
Date:   Tue Nov 29 22:05:30 2016 +0100

    Removed superseded `slavePreLaunchDockerEnvironmentDecorator` hook.
    
    Review: https://reviews.apache.org/r/54129/

commit f765828257cf0e0c43e6f110b204524da7dcf728
Author: Till Toenshoff <[email protected]>
Date:   Tue Nov 29 22:05:15 2016 +0100

    Added test for `slavePreLaunchDockerTaskExecutorDecorator` hook.
    
    Review: https://reviews.apache.org/r/54128/
{code}

> Hooks should allow sandbox dependent environment variables.
> -----------------------------------------------------------
>
>                 Key: MESOS-6396
>                 URL: https://issues.apache.org/jira/browse/MESOS-6396
>             Project: Mesos
>          Issue Type: Improvement
>    Affects Versions: 1.1.0
>            Reporter: Till Toenshoff
>            Assignee: Till Toenshoff
>              Labels: containerizer, docker, hooks, module
>             Fix For: 1.2.0
>
>
> The {{slaveExecutorEnvironmentDecorator}} hook is the only one that allows 
> mutating the executor environment of a Docker container. That callback has no 
> means of getting the location of the sandbox. That in turn means that it is 
> not possible for a hook to create files and respective environment variables 
> listing  paths within the sandbox for the executor to access.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to