[
https://issues.apache.org/jira/browse/MESOS-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126113#comment-16126113
]
Matthew Mead-Briggs commented on MESOS-7886:
--------------------------------------------
Thanks for the comments [~kaysoky] I'm glad to get some context before I decide
for sure on the way to go :-)
Security wise, is the logging your only concern? It's something we'd have to
consider but also something that we might be able to mitigate ourselves.
Regarding limiting business logic on the master: this would be adding a hook to
allow the user to add some logic right? I think I'm not fully grasping your
concern. Is there a case where we break something because of different agent
configurations, they all support environment variables right?
> Add master hook for setting environment variables
> -------------------------------------------------
>
> Key: MESOS-7886
> URL: https://issues.apache.org/jira/browse/MESOS-7886
> Project: Mesos
> Issue Type: Improvement
> Components: modules
> Reporter: Matthew Mead-Briggs
>
> At Yelp we're planning to integrate our secret store with our platform as a
> service which runs on Mesos.
> I was hoping to write a module to "inject" environment variables on the
> master side but the necessary hook doesn't currently exist. Such a hook
> already exists on the slave side. However, for this integration that would
> require me to give all the agents access to the secret store and I'd much
> prefer to limit this to the master side.
> There is already a hook for adding labels:
> https://github.com/apache/mesos/blob/72752fc6deb8ebcbfbd5448dc599ef3774339d31/include/mesos/hook.hpp#L44-L48
> So it seems it should be pretty easy to add one for setting environment
> variables too? I had a crack the other day but although I got my code to
> compile something was not working at runtime (note: I'm not a C++ dev). Is
> there any reason why we wouldn't want such a hook? If anyone can confirm that
> it's a sane thing to add then I'd be happy to spend some time trying to get
> it working (although I may need some help)!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
