[
https://issues.apache.org/jira/browse/MESOS-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366507#comment-16366507
]
ASF GitHub Bot commented on MESOS-8534:
---------------------------------------
Github user jieyu commented on a diff in the pull request:
https://github.com/apache/mesos/pull/263#discussion_r168651591
--- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
@@ -570,10 +570,17 @@ Future<Option<ContainerLaunchInfo>>
NetworkCniIsolatorProcess::prepare(
return Failure("Container has already been prepared");
}
+ bool needsSeparateNs = false;
+ if ((containerConfig.has_container_info() &&
+ containerConfig.container_info().network_infos().size() > 0) ||
+ !containerId.has_parent()) {
+ needsSeparateNs = true;
+ }
+
hashmap<string, ContainerNetwork> containerNetworks;
Option<string> hostname;
- if (!containerId.has_parent()) {
+ if (needsSeparateNs) {
const ExecutorInfo& executorInfo = containerConfig.executor_info();
if (!executorInfo.has_container()) {
--- End diff --
not yours, but let's remove this short circuit here. We should defer the
decision to below.
> Allow nested containers in TaskGroups to have separate network namespaces
> -------------------------------------------------------------------------
>
> Key: MESOS-8534
> URL: https://issues.apache.org/jira/browse/MESOS-8534
> Project: Mesos
> Issue Type: Task
> Components: containerization
> Reporter: Sagar Sadashiv Patwardhan
> Priority: Minor
> Labels: cni
>
> As per the discussion with [~jieyu] and [~avinash.mesos] , I am going to
> allow nested containers in TaskGroups to have separate namespaces. I am also
> going to retain the existing functionality, where nested containers can share
> namespaces with parent/root container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
