[
https://issues.apache.org/jira/browse/MESOS-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366508#comment-16366508
]
ASF GitHub Bot commented on MESOS-8534:
---------------------------------------
Github user jieyu commented on a diff in the pull request:
https://github.com/apache/mesos/pull/263#discussion_r168654738
--- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
@@ -820,18 +821,16 @@ Future<Nothing> NetworkCniIsolatorProcess::isolate(
CHECK_SOME(rootDir);
CHECK_SOME(pluginDir);
- if (containerId.has_parent()) {
+ if (!infos[containerId]->needsSeparateNs) {
--- End diff --
I'd make this more explicit.
```
// NOTE: DEBUG container should not have Info struct. Thus if the control
// reaches here, the container is not a DEBUG container.
if (isNestedContainer && joinParentNetwork)
```
> Allow nested containers in TaskGroups to have separate network namespaces
> -------------------------------------------------------------------------
>
> Key: MESOS-8534
> URL: https://issues.apache.org/jira/browse/MESOS-8534
> Project: Mesos
> Issue Type: Task
> Components: containerization
> Reporter: Sagar Sadashiv Patwardhan
> Priority: Minor
> Labels: cni
>
> As per the discussion with [~jieyu] and [~avinash.mesos] , I am going to
> allow nested containers in TaskGroups to have separate namespaces. I am also
> going to retain the existing functionality, where nested containers can share
> namespaces with parent/root container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
