[
https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375852#comment-16375852
]
Andrew Schwartzmeyer commented on MESOS-7397:
---------------------------------------------
This appears to only be a bug for single reviews. That is, it does not
reproduce for a chain (2 or more) of reviews that have been applied (or a
partially applied chain): with and without -c, it properly reports that the
patches failed to apply.
But in the case of a _single_ review being applied as a chain (like #57764
which has no dependencies), this bug reproduces.
> apply-reviews.py silently fails when using chain mode.
> ------------------------------------------------------
>
> Key: MESOS-7397
> URL: https://issues.apache.org/jira/browse/MESOS-7397
> Project: Mesos
> Issue Type: Bug
> Reporter: Till Toenshoff
> Priority: Minor
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error
> messages when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat}
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/
> [1067/1067] -> "57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)