[
https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375890#comment-16375890
]
Andrew Schwartzmeyer commented on MESOS-7397:
---------------------------------------------
With the patch for MESOS-8586, the edge case of attempting to apply a submitted
patch results in a warning (and the patch not being applied).
The slightly different case of applying a submitted review without the --chain
option results in an immediate error, because no "is submitted" test is
performed on the review.
For the case of a patch that is unsubmitted, it results in a "failed to apply"
error regardless of --chain.
> apply-reviews.py silently fails when using chain mode.
> ------------------------------------------------------
>
> Key: MESOS-7397
> URL: https://issues.apache.org/jira/browse/MESOS-7397
> Project: Mesos
> Issue Type: Bug
> Reporter: Till Toenshoff
> Assignee: Shubham Kumar
> Priority: Minor
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error
> messages when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat}
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/
> [1067/1067] -> "57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
