[ 
https://issues.apache.org/jira/browse/MESOS-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883340#comment-16883340
 ] 

Benjamin Mahler commented on MESOS-5037:
----------------------------------------

[~haosd...@gmail.com] foreachkey indeed sounds problematic for multimap.

I didn't follow the CPU load issue you found. Can you file a related ticket 
explaining it? Be sure to show the code in question that is inducing the cpu 
load, and attach perf data if possible.

> foreachkey behaviour is not expected in multimap
> ------------------------------------------------
>
>                 Key: MESOS-5037
>                 URL: https://issues.apache.org/jira/browse/MESOS-5037
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout
>            Reporter: haosdent
>            Priority: Major
>              Labels: foundations, stout
>
> Currently the {{foreachkey}} implementation is 
> {code}
> #define foreachkey(VAR, COL)                    \
>   foreachpair (VAR, __foreach__::ignore, COL)
> {code}
> This works in most structures. But in multimap, one key may map to multi 
> values. This means there are multi pairs which have same key. So when call 
> {{foreachkey}}, the {{key}} would duplicated when iteration. My idea to solve 
> this is we prefer call {{foreach}} on {{(COL).keys()}} if {{keys()}} method 
> exists in {{COL}}.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to