[ https://issues.apache.org/jira/browse/MESOS-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884044#comment-16884044 ]
haosdent commented on MESOS-5037: --------------------------------- [~bmahler] Sure, it is https://github.com/apache/mesos/blob/master/src/master/master.cpp#L7707-L7708 {code} void Master::__reregisterSlave( ... foreachkey (FrameworkID frameworkId, slaves.unreachableTasks.at(slaveInfo.id())) { ... foreach (TaskID taskId, slaves.unreachableTasks.at(slaveInfo.id()).get(frameworkId)) { {code} Our case is when network flapping, 3~4 agents reregister, then master would CPU full and could not process any requests during that period. > foreachkey behaviour is not expected in multimap > ------------------------------------------------ > > Key: MESOS-5037 > URL: https://issues.apache.org/jira/browse/MESOS-5037 > Project: Mesos > Issue Type: Bug > Components: stout > Reporter: haosdent > Priority: Major > Labels: foundations, stout > > Currently the {{foreachkey}} implementation is > {code} > #define foreachkey(VAR, COL) \ > foreachpair (VAR, __foreach__::ignore, COL) > {code} > This works in most structures. But in multimap, one key may map to multi > values. This means there are multi pairs which have same key. So when call > {{foreachkey}}, the {{key}} would duplicated when iteration. My idea to solve > this is we prefer call {{foreach}} on {{(COL).keys()}} if {{keys()}} method > exists in {{COL}}. -- This message was sent by Atlassian JIRA (v7.6.14#76016)