[
https://issues.apache.org/jira/browse/METRON-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034033#comment-16034033
]
ASF GitHub Bot commented on METRON-746:
---------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/577
@mmiklavc I didn't see any of that at all. All I saw was it either fixing
things, or in certain cases (e.g. commas starting newlines) that it just left
things alone. Autoformat won't fix everything automatically, because it won't
touch certain things like the comma stuff, unfortunately.
If there's any examples, or a particular file, I can take a look at it and
see if I can find a disconnect. I'll also take a look and see if I can find
any examples where a checkstyle error from autoformat is produced (at least
where there wasn't already one).
> Build Custom Checkstyle and IDE formatting settings
> ---------------------------------------------------
>
> Key: METRON-746
> URL: https://issues.apache.org/jira/browse/METRON-746
> Project: Metron
> Issue Type: Improvement
> Reporter: Justin Leet
> Assignee: Justin Leet
> Priority: Minor
>
> We need a custom checkstyle.xml based off the sun convention checkstyle.
> Based on a discussion thread, there are a few things that need to be setup
> * Two space indents
> * Line Length longer than 80 (pretty popular in the discussion, but not
> officially part of our code style)
> * Appropriate warn/error levels set so we don't immediately start failing
> every build.
> * Importable IntelliJ code style at minimum, but I'd also like to see Eclipse
> if possible to avoid forcing a given dev environment. IntelliJ allows for
> importing a checkstyle.xml to use as the basis. We can export the resulting
> formatting settings for people.
> * Ensure Travis actually runs checkstyle during our builds
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
