[
https://issues.apache.org/jira/browse/METRON-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054268#comment-16054268
]
ASF GitHub Bot commented on METRON-746:
---------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/577
I removed the Apache header from the checkstyle.xml, because after research
Checkstyle is LGPL and I don't even want to be in the questionable space of
adding Apache headers to their config files (even though I've seen other
projects do this). Including this is fine since it's just in our build tools,
not part of our releases.
To reflect this, an exception for checkstyle.xml on the RAT check has been
added.
Let me know if this is the incorrect strategy for handling this, and I'll
update appropriately.
> Build Custom Checkstyle and IDE formatting settings
> ---------------------------------------------------
>
> Key: METRON-746
> URL: https://issues.apache.org/jira/browse/METRON-746
> Project: Metron
> Issue Type: Improvement
> Reporter: Justin Leet
> Assignee: Justin Leet
> Priority: Minor
>
> We need a custom checkstyle.xml based off the sun convention checkstyle.
> Based on a discussion thread, there are a few things that need to be setup
> * Two space indents
> * Line Length longer than 80 (pretty popular in the discussion, but not
> officially part of our code style)
> * Appropriate warn/error levels set so we don't immediately start failing
> every build.
> * Importable IntelliJ code style at minimum, but I'd also like to see Eclipse
> if possible to avoid forcing a given dev environment. IntelliJ allows for
> importing a checkstyle.xml to use as the basis. We can export the resulting
> formatting settings for people.
> * Ensure Travis actually runs checkstyle during our builds
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
