[
https://issues.apache.org/jira/browse/METRON-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038923#comment-16038923
]
ASF GitHub Bot commented on METRON-906:
---------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/602#discussion_r120366655
--- Diff: metron-deployment/roles/ambari_config/vars/single_node_vm.yml ---
@@ -102,7 +102,7 @@ configurations:
required_configurations:
- metron-env:
- storm_rest_addr: "{{ groups.ambari_slave[0] }}:8744"
+ storm_rest_addr: "http://{{ groups.ambari_slave[0] }}:8744"
--- End diff --
It probably shouldn't be. I did that before the backwards compatibility
commit. It'll be assumed at the code level if no protocol is there anyway, so
do we have a preference on explicit vs. implicit?
It seems more like I need documentation around changing that parameter when
storm https is enabled (both non-Ambari and Ambari need it).
> Rest service storm configuration does not allow for proper URLs
> ---------------------------------------------------------------
>
> Key: METRON-906
> URL: https://issues.apache.org/jira/browse/METRON-906
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Simon Elliston Ball
> Assignee: Justin Leet
> Labels: newbie
>
> The storm.ui.url field does not accept a URL, but instead accepts a
> hostname, port and path, without the schema. The code then prepends http://
> This is somewhat confusing, and prevents us later moving to support ssl
> access to the api. The field should retain its name as url, but accept an
> actual url.
> Note this is a breaking config change, and will required documentation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
