[ 
https://issues.apache.org/jira/browse/METRON-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040813#comment-16040813
 ] 

ASF GitHub Bot commented on METRON-906:
---------------------------------------

Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/602#discussion_r120614845
  
    --- Diff: metron-deployment/roles/ambari_config/vars/single_node_vm.yml ---
    @@ -102,7 +102,7 @@ configurations:
     
     required_configurations:
       - metron-env:
    -      storm_rest_addr: "{{ groups.ambari_slave[0] }}:8744"
    +      storm_rest_addr: "http://{{ groups.ambari_slave[0] }}:8744"
    --- End diff --
    
    @cestella Thoughts?  @dlyle65535 is right that it's the definition of a 
specific cluster.  I'd argue that it's the user's responsibility to update 
anything afterwards when they set up SSL (e.g. through Ambari).  All I was 
thinking of documenting was just to ensure that field gets updated, but I'm not 
sure how useful that is anyway.


> Rest service storm configuration does not allow for proper URLs
> ---------------------------------------------------------------
>
>                 Key: METRON-906
>                 URL: https://issues.apache.org/jira/browse/METRON-906
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.3.1
>            Reporter: Simon Elliston Ball
>            Assignee: Justin Leet
>              Labels: newbie
>
> The storm.ui.url  field does not accept a URL, but instead accepts a 
> hostname, port and path, without the schema. The code then prepends http://  
> This is somewhat confusing, and prevents us later moving to support ssl 
> access to the api. The field should retain its name as url, but accept an 
> actual url.
> Note this is a breaking config change, and will required documentation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to