[
https://issues.apache.org/jira/browse/METRON-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039600#comment-16039600
]
ASF GitHub Bot commented on METRON-941:
---------------------------------------
Github user kylerichardson commented on the issue:
https://github.com/apache/metron/pull/579
Given these unit tests have been broken for quite some time and @ctramnitz
has thoroughly tested in his environment and that this is a relatively minor
change, I'm okay to move it forward especially with a JIRA in to address these
broken 'AbstractConfigTest' tests holistically in METRON-962.
+1 from me but would prefer a second to commit without tests.
@ctramnitz as discussed please upload public safe sample logs to the JIRA
to assist with test development.
-Kyle
> On Jun 5, 2017, at 5:40 PM, Matt Foley <[email protected]> wrote:
>
> @ctramnitz says (in email): "I didn’t touch unit tests because it was
already broken before.
> We agreed to put this into a separate ticket (METRON-962) as it applies
to other parsers as well.
> For now, METRON-941 fixes an actual bug (parsing is broken with the
current code)."
>
> @ottobackwards and @justinleet (principles on METRON-962), do you agree
we should go ahead and commit this without a viable PaloAltoParser unit test?
Or wait for METRON-962?
>
> @kylerichardson , what is your opinion on the issue?
> Thanks.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
> native PaloAlto parser corrupts message when having a comma in the payload
> --------------------------------------------------------------------------
>
> Key: METRON-941
> URL: https://issues.apache.org/jira/browse/METRON-941
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.4
> Environment: full-dev master
> Reporter: Christian Tramnitz
> Priority: Minor
>
> When a data field contains a comma (i.e. the URL, not too uncommon), the
> split(",") kicks in and the rest of the message if off by few fields due to
> positional definition.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
