[
https://issues.apache.org/jira/browse/METRON-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041328#comment-16041328
]
ASF GitHub Bot commented on METRON-941:
---------------------------------------
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/579
First, a note to @ctramnitz : Christian, please be patient with the long
cycle on this. It is not a reflection on your work, but rather a desire to
make sure that work gets appropriate consideration. Your work is very much
appreciated. We really do have a very strong bias in Apache toward test-driven
development, and so we tend to ask that new work provide unit tests, even if
those tests were lamentably lacking before the new work :-)
Anyway, thanks to fast work by @justinleet , METRON-962 is now in, and the
PaloAlto parser can be unit tested. Please rebase so it can be done. Since
the one file you changed has not been touched by recent commits, the rebase
should be painless. If you're not familiar with git rebase, ping me offline.
If my understanding of Justin's PR is correct, you can then just layer on
his bf8ce62 patch, and have a good start on testability. @justinleet is that
correct? Was it your intent that this patch will fully provide the unit
testing capability, or is it just the start? Thanks.
> native PaloAlto parser corrupts message when having a comma in the payload
> --------------------------------------------------------------------------
>
> Key: METRON-941
> URL: https://issues.apache.org/jira/browse/METRON-941
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.4
> Environment: full-dev master
> Reporter: Christian Tramnitz
> Priority: Minor
>
> When a data field contains a comma (i.e. the URL, not too uncommon), the
> split(",") kicks in and the rest of the message if off by few fields due to
> positional definition.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
