[
https://issues.apache.org/jira/browse/METRON-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039945#comment-16039945
]
ASF GitHub Bot commented on METRON-877:
---------------------------------------
GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/610
METRON-877 Extract core implementation and UDF support, create
metron-stellar module
## Contributor Comments
The design document has been available for some time at
https://docs.google.com/document/d/1EP7Jt4ePHe2A-_oboLl2QbN1muh7uKeET_kbpIgjcJM/edit#
I have now added a new section, starting on p. 7, titled "Retrospective:
Changes made for Parts 1 & 2" that details the specific changes actually done
in this PR to extract Stellar.
## Pull Request Checklist
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
The intent of these changes is to achieve an architecture change WITHOUT
any functional change. The continued working of all unit tests, integration
tests and real-world applications should result. In addition, it generates (in
metron-stellar/stellar-common/target) a stellar-common uber-jar (including all
dependencies), which among other things can run the Stellar shell as a
stand-alone Java application (although missing those Stellar functions that
remain as part of Metron):
```
java -cp target/stellar-common-0.4.0-uber.jar \
org.apache.metron.stellar.common.shell.StellarShell
```
Note that this PR does not yet have RPM generation (Step 6). Thus, the
Stellar jar will need to be manually added to the lib/ directory of test
deployments.
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [IN PROCESS] Have you verified the basic functionality of the build by
building and running locally with Vagrant full-dev environment or the
equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattf-horton/metron stellar-mod4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/610.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #610
----
commit 8af5fb58a667825c4a1da9aaef335581b6283034
Author: mattf-horton <[email protected]>
Date: 2017-06-05T22:15:15Z
Stellar extraction - first commit, steps 1 and 2.
----
> Extract core implementation and UDF support, create metron-stellar module
> -------------------------------------------------------------------------
>
> Key: METRON-877
> URL: https://issues.apache.org/jira/browse/METRON-877
> Project: Metron
> Issue Type: Sub-task
> Reporter: Matt Foley
> Assignee: Matt Foley
>
> Steps 1 & 2 in the design document. Get a compilable new module.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
