[
https://issues.apache.org/jira/browse/METRON-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040873#comment-16040873
]
ASF GitHub Bot commented on METRON-777:
---------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/530
@nickwallen I agree in philosophy, but this has been a running PR for
awhile that had plenty of dev list discussion around it before it was made.
There's already follow-on work being done, and I'm worried that it's going to
be an equally huge burden to split out everything at this point, but all on
@ottobackwards .
I think we should go ahead with this as one PR, and start a discuss thread
laying out the difficulties we've had (both past and present) and make it well
known that we strongly prefer PRs of large scope to come in as multiple,
smaller PRs for the sake of easier, more comprehensive reviewing in the future.
This may involve updating the dev guidelines to state this and that
contributors should be aware that a request to split apart unwieldy PRs is a
potential consequence. I don't think there is (or should be) a hard guideline,
but we're going to have to adjust to avoid repeating these types of things in
the future.
I do however, think that we need a more formalized test plan, just for no
other reason than that seems like the easiest way to dig into something of this
size.
> Create a plugin system for Metron based on 'NAR'
> ------------------------------------------------
>
> Key: METRON-777
> URL: https://issues.apache.org/jira/browse/METRON-777
> Project: Metron
> Issue Type: New Feature
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> The success of the Metron project will be greatly dependent on community
> participation, and with that the ability to adapt and extend Metron without
> having to maintain a fork of the project.
> As organizations and individuals look to extend the Metron system with custom
> parsers, enrichments, and stellar functions that may be proprietary in
> nature, the ability to develop and deploy these extensions outside the Metron
> code base is critically important.
> To that end, and after community discussion and proposal we create or
> formalize the 'plugin' development story in Metron.
> The proposal is to adapt the Apache Nifi NAR system for use in Metron. This
> will provide the system with:
> * archetype(s) for developer projects and independent development
> * defined packaging and metadata for 'plugin' products
> * loading and instantiation with classloader isolation capabilities
> * removing the necessity for shading plugin jars
> These capabilities will also enable other features, such as plugin lifecycle,
> plugin configuration+redeployment, and other things.
> The plugin archetypes and their installation will be a followon
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
