[
https://issues.apache.org/jira/browse/METRON-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043837#comment-16043837
]
ASF GitHub Bot commented on METRON-962:
---------------------------------------
Github user kylerichardson commented on the issue:
https://github.com/apache/metron/pull/612
'GrokAsaParser' is legacy OpenSOC I believe. It has been broken for some
time and when I rewrote the ASA parser I did it as 'BasicAsaParser'.
@justinleet Thanks for cleaning this up! I'm +1 for dropping
'GrokAsaParser'.
-Kyle
> On Jun 7, 2017, at 8:58 AM, justinleet <[email protected]> wrote:
>
> @kylerichardson What is the difference between the BasicAsaParser and the
GrokAsaParser? Are you able to shed some light on why both exist? The
motivation for the question is that minor changes had to be made to the
GrokAsaParser to get unit tests (and possibly the parser itself working).
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
> Configuration Based Unit Tests and Add integration tests
> --------------------------------------------------------
>
> Key: METRON-962
> URL: https://issues.apache.org/jira/browse/METRON-962
> Project: Metron
> Issue Type: Task
> Reporter: Christian Tramnitz
> Assignee: Justin Leet
> Priority: Minor
>
> The configuration based tests don't run, so paloalto and others do not have
> coverage.
> Some parsers are missing integration tests as well
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
