[ 
https://issues.apache.org/jira/browse/METRON-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086411#comment-16086411
 ] 

ASF GitHub Bot commented on METRON-1005:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/622#discussion_r127327990
  
    --- Diff: 
metron-analytics/metron-profiler/src/main/flux/profiler/remote.yaml ---
    @@ -29,7 +29,7 @@ components:
                 - name: "saltDivisor"
    --- End diff --
    
    I chose to require a flux file change here because this is not something 
that any old user should just change.  This is only configurable to allow for 
backwards compatibility.
    
    In addition, the IoC-like functionality that Flux provides makes it easier 
to set whatever configuration values are needed by a `RowKeyBuilder` (like salt 
divisor) without polluting the `RowKeyBuilder` interface.
    
    There is no such convenient IoC-like functionality when trying to 
instantiate the `RowKeyBuilder` from the client-side in `GetProfile`.


> Create Decodable Row Key for Profiler
> -------------------------------------
>
>                 Key: METRON-1005
>                 URL: https://issues.apache.org/jira/browse/METRON-1005
>             Project: Metron
>          Issue Type: Improvement
>    Affects Versions: 0.3.0
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>             Fix For: Next + 1
>
>
> To be able to answer the types of questions that I outlined in METRON-450, we 
> need a row key that is decodable.  Right now there is no logic to decode a 
> row key, nor is the existing row key easily decodable.  
> Once the row keys can be decoded, you could scan all of the row keys in the 
> Profiler's HBase table, decode each of them and extract things like, the 
> names of all your profiles, the names of entities within a profile, the 
> period duration of a given profile.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to