[
https://issues.apache.org/jira/browse/METRON-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097267#comment-16097267
]
ASF GitHub Bot commented on METRON-1054:
----------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/660#discussion_r128895474
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py
---
@@ -95,32 +95,46 @@ def init_hdfs_dir(self):
)
Logger.info('Done creating HDFS indexing directory')
- def start_indexing_topology(self):
- Logger.info("Starting Metron indexing topology:
{0}".format(self.__indexing_topology))
- start_cmd_template = """{0}/bin/start_elasticsearch_topology.sh \
+ def start_indexing_topology(self, env):
+ Logger.info('Starting ' + self.__indexing_topology)
+
+ if self.is_topology_active(env):
--- End diff --
Same deal with the negated condition
> Ambari Mpack Attempts to Kill Topologies That Are Not Running
> -------------------------------------------------------------
>
> Key: METRON-1054
> URL: https://issues.apache.org/jira/browse/METRON-1054
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Nick Allen
> Assignee: Nick Allen
> Fix For: 0.4.1
>
>
> The Ambari Metron MPack attempts to kill topologies that are not running. It
> also attempts to start topologies that are already running. It reports these
> conditions as errors.
> The MPack should not report errors when attempting to stop an already stopped
> topology nor when starting an already started topology.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
