[
https://issues.apache.org/jira/browse/METRON-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097268#comment-16097268
]
ASF GitHub Bot commented on METRON-1054:
----------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/660#discussion_r128895470
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
---
@@ -136,26 +136,37 @@ def init_kafka_acls(self):
self.set_kafka_acl_configured()
- def start_enrichment_topology(self):
+ def start_enrichment_topology(self, env):
Logger.info("Starting Metron enrichment topology:
{0}".format(self.__enrichment_topology))
- start_cmd_template = """{0}/bin/start_enrichment_topology.sh \
- -s {1} \
- -z {2}"""
- Logger.info('Starting ' + self.__enrichment_topology)
- Execute(start_cmd_template.format(self.__params.metron_home,
self.__enrichment_topology, self.__params.zookeeper_quorum),
- user=self.__params.metron_user)
+
+ if self.is_topology_active(env):
--- End diff --
Shouldn't we only be starting the topology if it's not active? I think
this condition needs to be negated.
> Ambari Mpack Attempts to Kill Topologies That Are Not Running
> -------------------------------------------------------------
>
> Key: METRON-1054
> URL: https://issues.apache.org/jira/browse/METRON-1054
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Nick Allen
> Assignee: Nick Allen
> Fix For: 0.4.1
>
>
> The Ambari Metron MPack attempts to kill topologies that are not running. It
> also attempts to start topologies that are already running. It reports these
> conditions as errors.
> The MPack should not report errors when attempting to stop an already stopped
> topology nor when starting an already started topology.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
