[
https://issues.apache.org/jira/browse/METRON-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102429#comment-16102429
]
ASF GitHub Bot commented on METRON-982:
---------------------------------------
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129718460
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java
---
@@ -17,10 +17,7 @@
*/
package org.apache.metron.rest.service.impl;
-import org.apache.metron.rest.model.TopologyResponse;
-import org.apache.metron.rest.model.TopologyStatus;
-import org.apache.metron.rest.model.TopologyStatusCode;
-import org.apache.metron.rest.model.TopologySummary;
+import org.apache.metron.rest.model.*;
--- End diff --
@merrimanr , heh, you made me go look this up!
As far as I can see, our coding standards, both
[here](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines#DevelopmentGuidelines-2.2CodeStyle)
and [here](http://www.oracle.com/technetwork/java/codeconvtoc-136057.html) are
silent on this topic.
There is a good discussion of the pros and cons
[here](https://stackoverflow.com/questions/147454/why-is-using-a-wild-card-with-a-java-import-statement-bad).
Despite the latter being a fairly old article, google did not show me any more
recent definitive policy statements.
I must admit that I think the "wildcard imports are evil" side have
slightly more weight in the argument, yet I personally find long lists of
explicit imports annoying and appreciate IntelliJ's default settings (more than
5 imports of the same package collapses to wildcard). Can you provide cites
that support your assertion regarding "most coding standards"?
If you are so moved, you might bring this up on the mailing list, perhaps
providing the citations above, and propose a vote to modify the Coding Style.
> REST STORM Support for supervisor summary
> -----------------------------------------
>
> Key: METRON-982
> URL: https://issues.apache.org/jira/browse/METRON-982
> Project: Metron
> Issue Type: Improvement
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> The supervisor summary can be used for information on the cluster including
> the number of slots etc
> StormStatusServiceImpl already calls the storm ui rest endpoints and should
> be extended to call:
> {code}
> /api/v1/supervisor/summary (GET)
> returns all supervisors summary
> Response Fields:
> Field Value Description
> id String Supervisor's id
> host String Supervisor's host name
> uptime String Shows how long the supervisor is running
> slotsTotal Integer Total number of available worker slots for this
> supervisor
> slotsUsed Integer Number of worker slots used on this supervisor
> Sample Response:
> json { "supervisors": [ { "id": "0b879808-2a26-442b-8f7d-23101e0c3696",
> "host": "10.11.1.7", "uptime": "5m 58s", "slotsTotal": 4, "slotsUsed": 3 } ] }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
