[
https://issues.apache.org/jira/browse/METRON-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103487#comment-16103487
]
ASF GitHub Bot commented on METRON-982:
---------------------------------------
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129897123
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java
---
@@ -17,10 +17,7 @@
*/
package org.apache.metron.rest.service.impl;
-import org.apache.metron.rest.model.TopologyResponse;
-import org.apache.metron.rest.model.TopologyStatus;
-import org.apache.metron.rest.model.TopologyStatusCode;
-import org.apache.metron.rest.model.TopologySummary;
+import org.apache.metron.rest.model.*;
--- End diff --
Thanks for checking me on this @mattf-horton. I was under the impression
we already voted to switch our coding standard to Google's based on the [Code
Style](http://mail-archives.apache.org/mod_mbox/metron-dev/201705.mbox/%3CCADu=u3a23q-aehhim6r0acezapaj9qjvg8hnurhr2hkdtvx...@mail.gmail.com%3E)
discussion on the dev list back in the beginning of May. There is also a
pending [PR](https://github.com/apache/metron/pull/577) that sets up Checkstyle
with the Google Code Style.
Was this not an official vote or was the wiki just not updated? If we did
switch, [Google Coding
Style](https://google.github.io/styleguide/javaguide.html#s3.3-import-statements)
does not allow wildcard imports.
This is probably one of those topics with no clear correct answer, similar
to spaces vs tabs. I personally am not a fan of wildcard statements because I
prefer to see exactly what is being imported.
> REST STORM Support for supervisor summary
> -----------------------------------------
>
> Key: METRON-982
> URL: https://issues.apache.org/jira/browse/METRON-982
> Project: Metron
> Issue Type: Improvement
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> The supervisor summary can be used for information on the cluster including
> the number of slots etc
> StormStatusServiceImpl already calls the storm ui rest endpoints and should
> be extended to call:
> {code}
> /api/v1/supervisor/summary (GET)
> returns all supervisors summary
> Response Fields:
> Field Value Description
> id String Supervisor's id
> host String Supervisor's host name
> uptime String Shows how long the supervisor is running
> slotsTotal Integer Total number of available worker slots for this
> supervisor
> slotsUsed Integer Number of worker slots used on this supervisor
> Sample Response:
> json { "supervisors": [ { "id": "0b879808-2a26-442b-8f7d-23101e0c3696",
> "host": "10.11.1.7", "uptime": "5m 58s", "slotsTotal": 4, "slotsUsed": 3 } ] }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
