[ 
https://issues.apache.org/jira/browse/METRON-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257650#comment-16257650
 ] 

ASF GitHub Bot commented on METRON-1319:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/843#discussion_r151798907
  
    --- Diff: 
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java
 ---
    @@ -96,6 +96,11 @@ public GroupResponse group(GroupRequest groupRequest) 
throws RestException {
       @Override
       public Map<String, FieldType> getColumnMetadata(List<String> indices) 
throws RestException {
         try {
    +      if (indices == null || indices.isEmpty()) {
    +        indices = getDefaultIndices();
    +        // metaalerts should be included by default in column metadata 
requests
    +        indices.add(METAALERT_TYPE);
    --- End diff --
    
    Why is the metaalert index added in most cases, except in the case of 
group?  


> Column Metadata REST service should use default indices on empty input
> ----------------------------------------------------------------------
>
>                 Key: METRON-1319
>                 URL: https://issues.apache.org/jira/browse/METRON-1319
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>
> A bug in the Column Metadata service where metadata was returned for all 
> indices when no indices were found was fixed in 
> https://github.com/apache/metron/pull/827.  This caused a regression in the 
> Alerts UI because it depends on the REST layer to figure out which indices to 
> include and passes an empty index list.  The Column Metadata service should 
> behave like the search service and default to a list of indices when none are 
> passed in.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to