[
https://issues.apache.org/jira/browse/METRON-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257659#comment-16257659
]
ASF GitHub Bot commented on METRON-1319:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r151801296
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java
---
@@ -132,6 +132,30 @@ public void testDefaultQuery() throws Exception {
sensorIndexingConfigService.delete("bro");
}
+ @Test
+ public void testDefaultColumnMetadata() throws Exception {
--- End diff --
Let me explain better. I assume this is testing that the set of default
indices are used. That's just not clear to me how we are verifying that here.
Whereas, in your other test case
`getColumnMetadataShouldProperlyGetDefaultIndices` that makes it very clear to
me what you are testing. :)
> Column Metadata REST service should use default indices on empty input
> ----------------------------------------------------------------------
>
> Key: METRON-1319
> URL: https://issues.apache.org/jira/browse/METRON-1319
> Project: Metron
> Issue Type: Bug
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
>
> A bug in the Column Metadata service where metadata was returned for all
> indices when no indices were found was fixed in
> https://github.com/apache/metron/pull/827. This caused a regression in the
> Alerts UI because it depends on the REST layer to figure out which indices to
> include and passes an empty index list. The Column Metadata service should
> behave like the search service and default to a list of indices when none are
> passed in.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
