[
https://issues.apache.org/jira/browse/METRON-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279170#comment-16279170
]
ASF GitHub Bot commented on METRON-1340:
----------------------------------------
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/857
Took a first pass at this and I feel like the e2e tests are much improved.
Great progress and good job so far. I was able to get several successful runs
whereas before it was difficult to get a single successful run.
A couple of comments/suggestions:
- I noticed a warning message stating I wasn't on a recent enough version
of nodejs. I think we should be using the maven frontend plugin to run tests
so that we guarantee a consistent version is used. I submitted a
[PR](https://github.com/iraghumitra/incubator-metron/pull/6) as an example of
how to do this.
- I noticed there are still several browser.sleep statements throughout the
tests (I counted 20). I think our goal should be to remove all of them. I
know some of these should definitely be removed (alerts-list.po.ts, line 87)
and may have just been missed. If there are cases where we MUST have them, I
think those cases needed to be discussed and justified.
- I feel like the "should expand all facets" and "should collapse all
facets" tests in alert-filters.e2e-spec.ts are unnecessary (and would allow us
to remove a couple browser.sleep statements). These tests are simply opening
and closing bootstrap widgets which is controlled by code we don't maintain
(bootstrap). I would instead prefer a test that selects a filter and checks
that the search box and results are properly updated.
- I have ran into these errors a couple times. Not sure if I just ended up
in a bad state somehow or if it's because I'm running tests through Maven:
```
✗ should have all the steps for meta alerts workflow
- Failed: unknown error: Element <span _ngcontent-c14=""
class="checkmark"></span> is not clickable at point (1278, 102). Other element
would receive the click: <div _ngcontent-c14="" class="col-1 px-0">...</div>
✗ should create a meta alert from nesting of more than one level
- Failed: unknown error: Element <i _ngcontent-c7="" aria-hidden="true"
class="fa fa-link" data-animation="false" data-placement="left"
data-toggle="tooltip" style="color: #32ABDF;" title="Merge Alerts"></i> is not
clickable at point (1350, 503). Other element would receive the click: <div
_ngcontent-c14="" class="metron-slider-pane-details load-right-to-left
dialog1x">...</div>
```
> Improve e2e tests for metron alerts
> -----------------------------------
>
> Key: METRON-1340
> URL: https://issues.apache.org/jira/browse/METRON-1340
> Project: Metron
> Issue Type: Bug
> Reporter: RaghuMitra
> Assignee: RaghuMitra
>
> Need to improve e2e tests in the following areas:
> - Tests should not be flaky
> - Remove the sleep ( This should implicitly make the tests run faster)
> - Truncate HBase table 'metron_update' before starting the tests
> - Improve the tests descriptions
> - Run the tests headless if possible
> - Check the node version and browser version before launching the tests
> The expected behavior is that there are no intermittent failures. Acceptance
> criteria: 5 consecutive runs without failures.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
