[
https://issues.apache.org/jira/browse/METRON-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280278#comment-16280278
]
ASF GitHub Bot commented on METRON-1340:
----------------------------------------
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/857#discussion_r155261159
--- Diff: metron-interface/metron-alerts/src/app/utils/constants.ts ---
@@ -38,5 +38,6 @@ export let TREE_SUB_GROUP_SIZE = 5;
export let DEFAULT_FACETS = ['source:type', 'ip_src_addr', 'ip_dst_addr',
'host', 'enrichments:geo:ip_dst_addr:country'];
export let DEFAULT_GROUPS = ['source:type', 'ip_src_addr', 'ip_dst_addr',
'host', 'enrichments:geo:ip_dst_addr:country'];
export let INDEXES = environment.indices ? environment.indices.split(',')
: [];
+export let POLLING_DEFAULT_STATE = environment.defaultPollingState;
--- End diff --
Would it be possible to change this to a better name? Something like
DISABLE_POLLING? Setting POLLING_DEFAULT_STATE to true to stop polling doesn't
make sense to me.
> Improve e2e tests for metron alerts
> -----------------------------------
>
> Key: METRON-1340
> URL: https://issues.apache.org/jira/browse/METRON-1340
> Project: Metron
> Issue Type: Bug
> Reporter: RaghuMitra
> Assignee: RaghuMitra
>
> Need to improve e2e tests in the following areas:
> - Tests should not be flaky
> - Remove the sleep ( This should implicitly make the tests run faster)
> - Truncate HBase table 'metron_update' before starting the tests
> - Improve the tests descriptions
> - Run the tests headless if possible
> - Check the node version and browser version before launching the tests
> The expected behavior is that there are no intermittent failures. Acceptance
> criteria: 5 consecutive runs without failures.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
