[
https://issues.apache.org/jira/browse/METRON-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286473#comment-16286473
]
ASF GitHub Bot commented on METRON-1344:
----------------------------------------
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/858#discussion_r156183357
--- Diff: metron-interface/metron-alerts/protractor.conf.js ---
@@ -25,27 +25,28 @@ var SpecReporter =
require('jasmine-spec-reporter').SpecReporter;
exports.config = {
allScriptsTimeout: 25000,
specs: [
- './e2e/login/login.e2e-spec.ts',
- './e2e/alerts-list/alerts-list.e2e-spec.ts',
+ // './e2e/login/login.e2e-spec.ts',
--- End diff --
Similar comment to the above about removing vs commenting out code.
> Externalize the infrastructural components using integration tests
> ------------------------------------------------------------------
>
> Key: METRON-1344
> URL: https://issues.apache.org/jira/browse/METRON-1344
> Project: Metron
> Issue Type: Improvement
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
>
> As we move towards adding the Alerts UI e2e test to our continuous build, we
> need to remove the dependence on vagrant full dev and provide equivalent
> infrastructure within Travis. This will include all the services that the
> e2e tests depend on including Kafka, Zookeeper, Elasticsearch (possibly
> HBase), and Metron REST.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)