[ 
https://issues.apache.org/jira/browse/METRON-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286474#comment-16286474
 ] 

ASF GitHub Bot commented on METRON-1344:
----------------------------------------

Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/858#discussion_r156183048
  
    --- Diff: 
metron-interface/metron-alerts/e2e/alerts-list/configure-table/configure-table.e2e-spec.ts
 ---
    @@ -58,26 +58,26 @@ describe('metron-alerts configure table', function() {
         page.saveConfigureColumns();
       });
     
    -  it('should rename columns from table configuration', () => {
    -    page.clearLocalStorage();
    -    page.navigateTo();
    -
    -    page.clickConfigureTable();
    -    page.renameColumn('enrichments:geo:ip_dst_addr:country', 'Country');
    -    page.saveConfigureColumns();
    -
    -    page.clickTableText('FR');
    -    expect(page.getSearchText()).toEqual('Country:FR');
    -    expect(page.getChangesAlertTableTitle('Alerts (169)')).toEqual('Alerts 
(25)');
    -    page.clickClearSearch();
    -
    -    expect(page.getChangesAlertTableTitle('Alerts (25)')).toEqual('Alerts 
(169)');
    -    page.setSearchText('Country:FR');
    -    expect(page.getChangesAlertTableTitle('Alerts (169)')).toEqual('Alerts 
(25)');
    -    page.clickClearSearch();
    -
    -    expect(page.getTableColumnNames()).toContain('Country', 'for renamed 
column names for alert list table');
    -
    -  });
    +  // it('should rename columns from table configuration', () => {
    --- End diff --
    
    Same here


> Externalize the infrastructural components using integration tests
> ------------------------------------------------------------------
>
>                 Key: METRON-1344
>                 URL: https://issues.apache.org/jira/browse/METRON-1344
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>
> As we move towards adding the Alerts UI e2e test to our continuous build, we 
> need to remove the dependence on vagrant full dev and provide equivalent 
> infrastructure within Travis.  This will include all the services that the 
> e2e tests depend on including Kafka, Zookeeper, Elasticsearch (possibly 
> HBase), and Metron REST.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to