[ 
https://issues.apache.org/jira/browse/METRON-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331139#comment-16331139
 ] 

ASF GitHub Bot commented on METRON-1090:
----------------------------------------

Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/687
  
    > @cestella: No, both the REPL and enrichments use the same method of 
assignment, the StellarAssignment class. It's just that assignment in stellar 
is available in multiple places.
    
    Ah, yes, I am familiar with `StellarAssignment`.  Ok, but 
`StellarAssignment` just takes an expression as input and returns the variable 
and expression.  It gets us to the red zone, but not the end zone.
    
    To really perform assignment, you still need to (1) execute the expression 
and (2) add the variable to a `VariableResolver`.  Those extra steps are 
performed currently in `AssignmentCommand` for the REPL and they must also be 
performed elsewhere for Enrichment, etc.
    
    I was thinking that we would have all of those steps performed in the same 
place.


> STELLAR Add Assignment capability to Stellar language
> -----------------------------------------------------
>
>                 Key: METRON-1090
>                 URL: https://issues.apache.org/jira/browse/METRON-1090
>             Project: Metron
>          Issue Type: New Feature
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
>
> Add support for =, +=, -=, *=, /= for variables in stellar.
> foo = 5  returns 5 AND sets foo to 5 if the VariableResolver supports it.
> The shell should be changed to assign variables using this syntax, because 
> exposing the left side to stellar allows catching errors for invalid keywords 
> in left side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to