[ 
https://issues.apache.org/jira/browse/METRON-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331149#comment-16331149
 ] 

ASF GitHub Bot commented on METRON-1090:
----------------------------------------

Github user cestella commented on the issue:

    https://github.com/apache/metron/pull/687
  
    @nickwallen Yes, you are absolutely correct.  Right now we do not have an 
approach to take a list of stellar expressions that are assignments, a variable 
resolver, a function resolver and execute that list of statements in a way that 
variables are updated.  At the time we punted on it due to limitations in the 
VariableResolver to update (also, it's not clear how to do that generally or 
even specifically in all circumstances).  All that being said, it might be nice 
to add a method to do that in `StellarAssignment` that presumes variable 
containers are maps.
    
    Anyway, that aside, this PR seems to not *force* that change since it's 
really just moving variable assignment into the language and not updating the 
resolver explicitly.  I'd suggest we tackle that as a follow-on and make a 
stellar-generic approach to update variable resolvers with new variables.


> STELLAR Add Assignment capability to Stellar language
> -----------------------------------------------------
>
>                 Key: METRON-1090
>                 URL: https://issues.apache.org/jira/browse/METRON-1090
>             Project: Metron
>          Issue Type: New Feature
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
>
> Add support for =, +=, -=, *=, /= for variables in stellar.
> foo = 5  returns 5 AND sets foo to 5 if the VariableResolver supports it.
> The shell should be changed to assign variables using this syntax, because 
> exposing the left side to stellar allows catching errors for invalid keywords 
> in left side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to