[ 
https://issues.apache.org/jira/browse/METRON-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345633#comment-16345633
 ] 

ASF GitHub Bot commented on METRON-1419:
----------------------------------------

Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/911#discussion_r164846538
  
    --- Diff: 
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java
 ---
    @@ -443,11 +495,11 @@ public void all_query_returns_all_results() throws 
Exception {
         Assert.assertEquals(10, results.size());
         for(int i = 0;i < 5;++i) {
           Assert.assertEquals("snort", 
results.get(i).getSource().get("source:type"));
    -      Assert.assertEquals(10 - i, 
results.get(i).getSource().get("timestamp"));
    +      Assert.assertEquals(10 - i + "", 
results.get(i).getSource().get("timestamp").toString());
    --- End diff --
    
    Why are all the timestamps strings now?


> Create a SolrDao
> ----------------
>
>                 Key: METRON-1419
>                 URL: https://issues.apache.org/jira/browse/METRON-1419
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Assignee: Ryan Merriman
>            Priority: Major
>
> Create an implementation of the IndexDao for Solr. This will involve 
> implementing the various IndexDao methods using the SolrJ library and also 
> providing a SolrSearchIntegrationTest that extends SearchIntegrationTest 
> (similar to ElasticsearchSearchIntegrationTest). An integration test similar 
> to ElasticsearchUpdateIntegrationTest should also be included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to