[
https://issues.apache.org/jira/browse/METRON-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345826#comment-16345826
]
ASF GitHub Bot commented on METRON-1419:
----------------------------------------
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/911#discussion_r164881237
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchDao.java
---
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.indexing.dao.search;
+
+import java.io.IOException;
+import java.util.List;
+import org.apache.metron.indexing.dao.update.Document;
+
+public interface SearchDao {
--- End diff --
I was undecided as to whether we should do it in this PR or a future one
and also wanted to make sure people liked it. Will make this change.
> Create a SolrDao
> ----------------
>
> Key: METRON-1419
> URL: https://issues.apache.org/jira/browse/METRON-1419
> Project: Metron
> Issue Type: Sub-task
> Reporter: Justin Leet
> Assignee: Ryan Merriman
> Priority: Major
>
> Create an implementation of the IndexDao for Solr. This will involve
> implementing the various IndexDao methods using the SolrJ library and also
> providing a SolrSearchIntegrationTest that extends SearchIntegrationTest
> (similar to ElasticsearchSearchIntegrationTest). An integration test similar
> to ElasticsearchUpdateIntegrationTest should also be included.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
