Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/970
  
    > @justinleet Are you more interested into breaking things out into more 
classes than that, just breaking apart functions more so they're more easily 
tested, some combination of both?
    
    > @justinleet Is breaking the meta alert dao into the various sub functions 
(Search, Update, etc.) + pulling out the calculate logic + at least a 
refactoring pass for testability a good first step in moving this forward?"
    
    Yes, I like it; that works.  I will be happy if we get better unit test 
coverage on all of this. 
    



---

Reply via email to