Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/970 It is definitely looking better. I am liking the progress. But I still think having overly broad interfaces that do everything is causing problems; primarily `IndexDao` and also `MetaAlertDao`. Neither of those need to exist. For example... * The `MetaAlertService` does not need a `MetaAlertDao`. * If the `MetaAlertService` needs to update meta-alerts then it should directly use a `MetaAlertUpdateDao`. * If the `MetaAlertService` needs to search for meta-alerts then it should directly use a `MetaAlertSearchDao`. I can submit a PR to your branch, if you like.
---