Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/975
  
    If I remember correctly, there was a technical challenge writing unit tests 
for the ElasticsearchDao.  The ES client library was difficult to mock which 
made the tests verbose and difficult to understand.  
    
    That isn't necessarily true for the Solr client though so I'm happy to take 
add some unit tests.  If we're going to do it we might as well do it right and 
add tests for the whole class.  Are you ok reviewing that in this PR?


---

Reply via email to