Github user nickwallen commented on a diff in the pull request:
    --- Diff: 
    @@ -176,19 +179,23 @@ private SolrQuery buildSearchRequest(
    -    String collections = 
    -    query.set("collection", collections);
    +    query.set("collection", getCollections(searchRequest.getIndices()));
    --- End diff --
    This is the key fix for the bug that you found.  When I comment this out 
and run the tests, the integration test does fail, which is great.  
    Unfortunately, I would have expected the `SolrSearchDaoTest` to fail too, 
but it did not.  If you think it is easy enough to fail a unit test on this 
condition, it would be a good add.  


Reply via email to