Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1010#discussion_r188243982
--- Diff:
metron-interface/metron-alerts/src/app/service/global-config.service.ts ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import {Injectable, Inject} from '@angular/core';
+import {Http, Headers, RequestOptions, Response, ResponseOptions} from
'@angular/http';
+import {Observable} from 'rxjs/Observable';
+import {HttpUtil} from '../utils/httpUtil';
+
+@Injectable()
+export class GlobalConfigService {
+ url = 'api/v1/global/config';
+ defaultHeaders = {'Content-Type': 'application/json',
'X-Requested-With': 'XMLHttpRequest'};
+
+ private globalConfig = {};
+
+ constructor(private http: Http) {
--- End diff --
Thanks for pointing this out, @merrimanr. Most of the file was carried over
from metron-config, and after taking another look I agree that the constructor
should be empty. I'm also going to remove the post and delete methods, as they
are not used in metron-alerts currently.
---
