Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1010#discussion_r189060226
  
    --- Diff: 
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.ts
 ---
    @@ -77,12 +80,24 @@ export class TableViewComponent implements OnChanges {
                   searchService: SearchService,
                   metronDialogBox: MetronDialogBox,
                   updateService: UpdateService,
    -              metaAlertService: MetaAlertService) {
    +              metaAlertService: MetaAlertService,
    +              globalConfigService: GlobalConfigService) {
         this.router = router;
         this.searchService = searchService;
         this.metronDialogBox = metronDialogBox;
         this.updateService = updateService;
         this.metaAlertService = metaAlertService;
    +    this.globalConfigService = globalConfigService;
    +  }
    +
    +  ngOnInit() {
    +    this.globalConfigService.get().subscribe((config: {}) => {
    +      this.globalConfig = config;
    +      if (this.globalConfig['source.type.field'] === 'source.type' && 
!this.alertsColumnsToDisplay['source.type']) {
    --- End diff --
    
    I don't think this logic is correct.  What happens if you have 
"source.type" selected as a table column?  I went in a updated by local storage 
directly and ended up with 2 "source.type" columns.


---

Reply via email to