[
https://issues.apache.org/jira/browse/METRON-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502407#comment-16502407
]
ASF GitHub Bot commented on METRON-1603:
----------------------------------------
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/1051
METRON-1603: Fix multivalue field errors in Bro Solr schema
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1603
Ran some sample from our unit testing infrastructure that pointed out some
shortcomings in the Bro schema not revealed by our standard sensor-stub data
that's setup by default as a service for demo purposes in full dev. For Bro
records that have multi-valued fields (i.e. an array of values), you will see
an exception when indexing in Solr if the collection does not explicitly set
multiValued=true for that field.
I modified the Solr schema check integration test data to flex all of the
multi-valued fields I found properly.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)? - this is pertinent to the Solr upgrade feature
branch.
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
n/a
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron fix-schema-multivalued
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1051.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1051
----
commit 692a888e00ccedf900aa176ed35ec9d187875ab0
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-06-04T21:44:41Z
METRON-1603: Fix multivalue field errors in Bro Solr schema
----
> Fix multivalue field errors in Bro Solr schema
> -----------------------------------------------
>
> Key: METRON-1603
> URL: https://issues.apache.org/jira/browse/METRON-1603
> Project: Metron
> Issue Type: Bug
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
> Running some additional test data through Bro with multiValued fields
> revealed that the Solr schema for Bro needs some attention. Exceptions are
> thrown like the following for fields that may have many values but aren't
> declared as such in the Solr schema.
> {code:java}
> 2018-06-05 07:34:11.903 o.a.s.d.executor Thread-6-indexingBolt-executor[3 3]
> [ERROR]
> org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException: Error
> from server at http://10.0.2.15:7574/solr/bro: ERROR:
> [doc=26643986-b4ce-4ffe-b84e-6fe45143ac16] multiple values encountered for
> non multiValued field answers: [www.cisco.com.akadns.net,
> origin-www.cisco.com, 2001:420:1201:2::a]
> at
> org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:612)
> ~[stormjar.jar:?]
> at
> org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:279)
> ~[stormjar.jar:?]
> at
> org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:268)
> ~[stormjar.jar:?]
> at
> org.apache.solr.client.solrj.impl.LBHttpSolrClient.doRequest(LBHttpSolrClient.java:447)
> ~[stormjar.jar:?]
> at
> org.apache.solr.client.solrj.impl.LBHttpSolrClient.request(LBHttpSolrClient.java:388)
> ~[stormjar.jar:?]
> at
> org.apache.solr.client.solrj.impl.CloudSolrClient.sendRequest(CloudSolrClient.java:1383)
> ~[stormjar.jar:?]
> at
> org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1134)
> ~[stormjar.jar:?]
> at
> org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1073)
> ~[stormjar.jar:?]
> at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160)
> ~[stormjar.jar:?]
> at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106)
> ~[stormjar.jar:?]
> at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71)
> ~[stormjar.jar:?]
> at org.apache.metron.solr.writer.SolrWriter.write(SolrWriter.java:208)
> ~[stormjar.jar:?]
> at
> org.apache.metron.writer.BulkWriterComponent.flush(BulkWriterComponent.java:239)
> [stormjar.jar:?]
> at
> org.apache.metron.writer.BulkWriterComponent.write(BulkWriterComponent.java:217)
> [stormjar.jar:?]
> at
> org.apache.metron.writer.bolt.BulkMessageWriterBolt.execute(BulkMessageWriterBolt.java:258)
> [stormjar.jar:?]
> at
> org.apache.storm.daemon.executor$fn__10252$tuple_action_fn__10254.invoke(executor.clj:735)
> [storm-core-1.1.0.2.6.5.0-292.jar:1.1.0.2.6.5.0-292]
> at
> org.apache.storm.daemon.executor$mk_task_receiver$fn__10171.invoke(executor.clj:466)
> [storm-core-1.1.0.2.6.5.0-292.jar:1.1.0.2.6.5.0-292]
> at
> org.apache.storm.disruptor$clojure_handler$reify__9685.onEvent(disruptor.clj:40)
> [storm-core-1.1.0.2.6.5.0-292.jar:1.1.0.2.6.5.0-292]
> at
> org.apache.storm.utils.DisruptorQueue.consumeBatchToCursor(DisruptorQueue.java:472)
> [storm-core-1.1.0.2.6.5.0-292.jar:1.1.0.2.6.5.0-292]
> at
> org.apache.storm.utils.DisruptorQueue.consumeBatchWhenAvailable(DisruptorQueue.java:451)
> [storm-core-1.1.0.2.6.5.0-292.jar:1.1.0.2.6.5.0-292]
> at
> org.apache.storm.disruptor$consume_batch_when_available.invoke(disruptor.clj:73)
> [storm-core-1.1.0.2.6.5.0-292.jar:1.1.0.2.6.5.0-292]
> at
> org.apache.storm.daemon.executor$fn__10252$fn__10265$fn__10320.invoke(executor.clj:855)
> [storm-core-1.1.0.2.6.5.0-292.jar:1.1.0.2.6.5.0-292]
> at org.apache.storm.util$async_loop$fn__553.invoke(util.clj:484)
> [storm-core-1.1.0.2.6.5.0-292.jar:1.1.0.2.6.5.0-292]
> at clojure.lang.AFn.run(AFn.java:22) [clojure-1.7.0.jar:?]
> at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
